Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column for signature metadata #971

Closed
romanstrobl opened this issue Aug 21, 2023 · 1 comment · Fixed by #985
Closed

Add column for signature metadata #971

romanstrobl opened this issue Aug 21, 2023 · 1 comment · Fixed by #985

Comments

@romanstrobl
Copy link
Member

romanstrobl commented Aug 21, 2023

PowerAuth server should support mutliple signature types, hence columns signature_data_method and signature_data_uri_id in table pa_signature_audit should be generified into a single JSON column e.g. signature_metadata.

Sample structure of contents of column signature_metadata after migration to JSON format:

{
    "signature_data_method": "POST",
    "signature_data_uri_id": "/authorize"
}

Other signature types will use dedicated JSONs. Let's prepare classes which model various signature types, for this release only the PowerAuth signature model class type.

@romanstrobl romanstrobl self-assigned this Aug 21, 2023
jandusil added a commit that referenced this issue Aug 24, 2023
- Add new column signature_metadata, remove merged columns signature_data_method and signature_data_uri_id, document it in liquibase
- Edit entity class, introduce new converter
@jandusil jandusil linked a pull request Aug 24, 2023 that will close this issue
jandusil added a commit that referenced this issue Aug 24, 2023
jandusil added a commit that referenced this issue Aug 28, 2023
jandusil added a commit that referenced this issue Aug 29, 2023
- Make the change retrospective in terms of liquibase
jandusil added a commit that referenced this issue Aug 30, 2023
- Introduce abstraction for SignatureMetadata
jandusil added a commit that referenced this issue Aug 30, 2023
- Add a test
- Introduce more generic approach
jandusil added a commit that referenced this issue Aug 30, 2023
- Add a test
- Introduce more generic approach
jandusil added a commit that referenced this issue Sep 5, 2023
- Change type of signature_metadata to clob
- Incorporate code review comments
jandusil added a commit that referenced this issue Sep 5, 2023
- Incorporate code review comments
jandusil added a commit that referenced this issue Sep 5, 2023
- Incorporate code review comments
jandusil added a commit that referenced this issue Sep 6, 2023
- Incorporate code review comments
jandusil added a commit that referenced this issue Sep 6, 2023
jandusil added a commit that referenced this issue Sep 6, 2023
- Remove redundant extension
jandusil added a commit that referenced this issue Sep 6, 2023
jandusil added a commit that referenced this issue Sep 6, 2023
* Fix #971: Add column for signature metadata
- Add new column signature_metadata, remove merged columns signature_data_method and signature_data_uri_id, document it in liquibase
- Edit entity class, introduce new converter
- Propagate changes
- Introduce abstraction for SignatureMetadata
- Add tests
@banterCZ
Copy link
Member

A follow-up to #500

banterCZ added a commit that referenced this issue Sep 11, 2023
banterCZ added a commit that referenced this issue Sep 11, 2023
Document signature_metadata db column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants