Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticateUsingBiometry doesn't increase fail counter #495

Closed
hvge opened this issue Oct 28, 2022 · 0 comments
Closed

authenticateUsingBiometry doesn't increase fail counter #495

hvge opened this issue Oct 28, 2022 · 0 comments

Comments

@hvge
Copy link
Member

hvge commented Oct 28, 2022

If biometric authentication fails in authenticateUsingBiometry function, then the fake biometry factor key is not generated. The result is that fail counter is not increased on the server. This bug may affect our react-native clients, because the function is used internally to pre-authorize biometry in case of reusable authentication object is requested.

The implementation should be simple - just move the logic that determine that fake key should be generated from signatureKeysForAuthentication into biometryRelatedKeyWithAuthentication function.


On top of that, we may implement a few nice enhancements to the function. Right now, our react-native wrapper suffer with issue that if biometry is requested on iOS simulator, then there's no biometry dialog displayed. This is because on simulator, the direct access to the biometry protected keychain item always succeed, with no dialog displayed. On opposite to that, if LAContext.evaluatePolicy is used, then biometric dialog is properly displayed and the developer can decide whether it should fail or success.

So, we should reimplement authenticateUsingBiometry with using LAContext with the following benefits:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant