Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dark mode cache #49

Open
wtLau opened this issue Mar 11, 2021 · 0 comments
Open

feat: add dark mode cache #49

wtLau opened this issue Mar 11, 2021 · 0 comments
Assignees
@wtLau
Labels
feat New feature or request frontend Good First Commit 😊 This is a good issue to tackle if you are interested to contribute :) Ping me if you need info

Comments

@wtLau
Copy link
Owner

wtLau commented Mar 11, 2021 •
edited
Loading

Estimated Time (Hours):

Abstract:

Store them in local storage so re-visiting the webpage should use the same setting

Expected Features:

  • [ ]

Prerequisite

Detail steps of implementation

  • Create a hook or lib to store and retrieve theme settings on the toggle click
  • It should be stored in local storage as isDarkMode, default to true
  • Theme should read this before rendering to avoid white turn-black flash

Additional Context
@wtLau wtLau added feat New feature or request frontend labels Mar 11, 2021
@wtLau wtLau self-assigned this Mar 11, 2021
@wtLau wtLau added the Good First Commit 😊 This is a good issue to tackle if you are interested to contribute :) Ping me if you need info label Oct 19, 2022
@wtLau wtLau changed the title [FEATURE]- Cache Theme mode feat: add dark mode cache Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtLau wtLau

Labels
feat New feature or request frontend Good First Commit 😊 This is a good issue to tackle if you are interested to contribute :) Ping me if you need info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wtLau