Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper scaling in getScaledFrameAtTime() #226

Open
3c71 opened this issue Mar 20, 2020 · 0 comments
Open

Implement proper scaling in getScaledFrameAtTime() #226

3c71 opened this issue Mar 20, 2020 · 0 comments

Comments

@3c71
Copy link

3c71 commented Mar 20, 2020

When requesting a frame, we don't necessarily know it's size in advance, hence ratio is unknown.

On stock Android MediaMetadataRetriever, passing the desired size as a square doesn't affect the resulting ratio of the thumbnail, it is properly scaled to fit within the desired size.

I tested in release 1.0.14, and I end-up with distorted thumbnails, mostly square while they are 16:9 or 21:9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant