Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Enhance error reporting, and warning/error messages lacking information #8

Open
leandor opened this issue Oct 16, 2016 · 2 comments
Open

Enhance error reporting, and warning/error messages lacking information #8

leandor opened this issue Oct 16, 2016 · 2 comments
Assignees
@leandor
Labels
goal Long term goal. May be code-related or a meta goal. papi Issue is primarily related to the Python API.
Milestone
Code Quality

Comments

@leandor
Copy link
Contributor

leandor commented Oct 16, 2016 •
edited
Loading

Based on forum post here

"RecordProcessor: Warning - Information lost. Record skipped with duplicate formID: 00156F6A"

Generated by a duplicated record. Problem is there's no context information about which mod in the load list has the problem, and what was the problem in the first place.

Vorians provided an ESP to help reproduce the problem, which will end being uploaded as part of a test case. But for now I've put it on my Dropbox here since I cannot attach that type of file to GITHUB (it probably scans the ZIP and rejects the ESP inside since it doesn't know about it.)
@leandor leandor added bug Acknowledged bug in the program. goal Long term goal. May be code-related or a meta goal. papi Issue is primarily related to the Python API. labels Oct 23, 2016
leandor added a commit that referenced this issue Oct 24, 2016
@leandor
(ref. #8) Change to RecordProcessor::Accept()
37d793f 
Moved the implementation of RecordProcessor::Accept() from the header
to the cpp file.

Reason is that both GenericRecord.h and ModFile.h includes each other,
so in GenericRecord.h ModFile struct is not fully declared.  So any use
of its members triggers a compile error.
leandor added a commit that referenced this issue Oct 24, 2016
@leandor
(ref. #8) Change to RecordProcessor::Accept()
50f5a1f 
Patched Accept implementation to print out the name of the MOD
triggering the warning.
leandor added a commit that referenced this issue Oct 24, 2016
@leandor
(ref. #8) Added test for DupedRecords example
3c2971f 
Added a test file for loading and debugging the duped file example, so
I can enhance the info printed by CBash.
leandor added a commit that referenced this issue Oct 24, 2016
@leandor
(ref. #8) Change to RecordProcessor::Accept()
dda8a62 
Added extra info to what is being printed.
 - Added Record Type string (i.e. 'REFR', 'ACHR', etc)
 - Added MOD id number
@leandor leandor self-assigned this Oct 24, 2016
leandor added a commit that referenced this issue Oct 28, 2016
@leandor
(ref. #8) Change to RecordProcessor::Accept()
808ef45 
Moved the implementation of RecordProcessor::Accept() from the header
to the cpp file.

Reason is that both GenericRecord.h and ModFile.h includes each other,
so in GenericRecord.h ModFile struct is not fully declared.  So any use
of its members triggers a compile error.
leandor added a commit that referenced this issue Oct 28, 2016
@leandor
(ref. #8) Change to RecordProcessor::Accept()
4416e1b 
Patched Accept implementation to print out the name of the MOD
triggering the warning.

Added extra info to what is being printed.
 - Added Record Type string (i.e. 'REFR', 'ACHR', etc)
 - Added MOD id number
leandor added a commit that referenced this issue Oct 28, 2016
@leandor
(ref. #8) Added test for DupedRecords example
f8b0302 
Added a test file for loading and debugging the duped file example, so
I can enhance the info printed by CBash.
@Infernio Infernio removed the bug Acknowledged bug in the program. label Sep 20, 2019
@Infernio
Copy link
Member

Infernio commented Sep 20, 2019 •
edited
Loading

ref #22
Using this as a general hub for better error reporting instead.

@Infernio Infernio added this to the Code Quality milestone Sep 20, 2019
@Infernio
Copy link
Member

Taken from #2:

  • Error messages - whenever an error is encountered we just return: "Function returned an error code." - :nocomments:

No idea if it still applies, but putting it here for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leandor leandor

Labels
goal Long term goal. May be code-related or a meta goal. papi Issue is primarily related to the Python API.
Projects
None yet
Milestone
Code Quality
Development

No branches or pull requests
2 participants
@leandor @Infernio