Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

ObCollection changes the current working directory #20

Open
Utumno opened this issue May 6, 2017 · 2 comments
Open

ObCollection changes the current working directory #20

Utumno opened this issue May 6, 2017 · 2 comments
Assignees
@leandor
Labels
bug Acknowledged bug in the program.
Milestone
0.8.0

Comments

@Utumno
Copy link
Member

Utumno commented May 6, 2017

Probably on Load ? This could be the root of many hard to track bugs in Bash and must be fixed
@Utumno Utumno added the bug Acknowledged bug in the program. label May 6, 2017
Utumno added a commit to wrye-bash/wrye-bash that referenced this issue May 7, 2017
@Utumno
[!]Fixup - using ObCollection would change the current working dir:
82e0136 
Happily we used it in a context manager so it was easily monkey patched,
but CBash must be fixed - wrye-bash/CBash#20
Idea from: http://stackoverflow.com/a/13197763/281545
The change of cwd would have unpredictable consequences - probably the
eternal Installer._move bug, that was only affecting oblivion but not
Skyrim (no CBash), was due to this. However it was maybe masking bugs
also, so things may break - hence the !
ObCollection was using __slots__ while not a new style class, fixed.
import struct was unused

Signed-off-by: MrD <[email protected]>
@leandor leandor self-assigned this Jul 8, 2017
@leandor
Copy link
Contributor

leandor commented Jul 8, 2017

Posting here for the record! I didn't see this issue before :)

I'll try to make a new branch depending on the current CBash's 'dev' and try to fix this during next week as I'm have some spare time to work on it.... but probably it'll take at least one week to be sure I did the changes correctly and tested everything... there are still many parts of the code I haven't seen yet!

@Utumno
Copy link
Member Author

Utumno commented May 12, 2018

It's somewhere in cint.ObCollection#addMod - this needs to be fixed trips Bash every so often plus it's a code smell - the lib should not change the cwd

Utumno added a commit to wrye-bash/wrye-bash that referenced this issue May 29, 2018
@Utumno
Another fix for CBash changing the working dir
8cf1906 
See: 82e0136
Unfortunbatelly `with` is not used with the patch Current collection

wrye-bash/CBash#20

Some random typos and string fixes

Signed-off-by: MrD <[email protected]>
Utumno added a commit to wrye-bash/wrye-bash that referenced this issue Jul 3, 2018
@Utumno
Another fix for CBash changing the working dir:
05eb81f 
See: 82e0136 and
https://afkmods.iguanadons.net/index.php?/topic/4966-wrye-bash-all-games/&do=findComment&comment=172717
Unfortunately `with` is not used with the patch Current collection

wrye-bash/CBash#20

Some random typos and string fixes and wrapping - I also changed the
official thread link (although we need a global for this and this
message should be reworded anyway)
@Infernio Infernio added this to the 0.8.0 milestone Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leandor leandor

Labels
bug Acknowledged bug in the program.
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@leandor @Utumno @Infernio