From 1c7adb644432728bbe0921bda5e04604f955fe41 Mon Sep 17 00:00:00 2001
From: Mateusz Russak <mateusz@russak.biz>
Date: Mon, 19 Feb 2024 13:00:24 +0100
Subject: [PATCH 1/2] chore: moved CoreIFrame and CorePDF to embeds folder

---
 ui/src/core/templateMap.ts                         |  4 ++--
 ui/src/core_components/{ => embeds}/CoreIFrame.vue | 10 +++++-----
 ui/src/core_components/{ => embeds}/CorePDF.vue    |  8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)
 rename ui/src/core_components/{ => embeds}/CoreIFrame.vue (87%)
 rename ui/src/core_components/{ => embeds}/CorePDF.vue (86%)

diff --git a/ui/src/core/templateMap.ts b/ui/src/core/templateMap.ts
index 535ddd02f..de4e0c0a8 100644
--- a/ui/src/core/templateMap.ts
+++ b/ui/src/core/templateMap.ts
@@ -19,8 +19,8 @@ import CoreSeparator from "../core_components/CoreSeparator.vue";
 import CoreTab from "../core_components/CoreTab.vue";
 import CoreTabs from "../core_components/CoreTabs.vue";
 import CoreImage from "../core_components/CoreImage.vue";
-import CorePDF from "../core_components/CorePDF.vue";
-import CoreIFrame from "../core_components/CoreIFrame.vue";
+import CorePDF from "../core_components/embeds/CorePDF.vue";
+import CoreIFrame from "../core_components/embeds/CoreIFrame.vue";
 import CoreTimer from "../core_components/CoreTimer.vue";
 import CoreWebcamCapture from "../core_components/CoreWebcamCapture.vue";
 import CoreVegaLiteChart from "../core_components/CoreVegaLiteChart.vue";
diff --git a/ui/src/core_components/CoreIFrame.vue b/ui/src/core_components/embeds/CoreIFrame.vue
similarity index 87%
rename from ui/src/core_components/CoreIFrame.vue
rename to ui/src/core_components/embeds/CoreIFrame.vue
index faeb2f7d7..2e9935125 100644
--- a/ui/src/core_components/CoreIFrame.vue
+++ b/ui/src/core_components/embeds/CoreIFrame.vue
@@ -10,8 +10,8 @@
 </template>
 
 <script lang="ts">
-import { FieldType } from "../streamsyncTypes";
-import { cssClasses } from "../renderer/sharedStyleFields";
+import { FieldType } from "../../streamsyncTypes";
+import { cssClasses } from "../../renderer/sharedStyleFields";
 
 const description = "A component to embed an external resource in an iframe.";
 
@@ -48,19 +48,19 @@ export default {
 
 <script setup lang="ts">
 import { Ref, inject, ref } from "vue";
-import injectionKeys from "../injectionKeys";
+import injectionKeys from "../../injectionKeys";
 
 const rootEl:Ref<HTMLElement> = ref(null); 
 const fields = inject(injectionKeys.evaluatedFields);
 
-function handleLoad(ev) {
+function handleLoad() {
 	const event = new CustomEvent("ss-load");
 	rootEl.value.dispatchEvent(event);
 }
 </script>
 
 <style scoped>
-@import "../renderer/sharedStyles.css";
+@import "../../renderer/sharedStyles.css";
 
 .CoreIFrame {
   position: relative;
diff --git a/ui/src/core_components/CorePDF.vue b/ui/src/core_components/embeds/CorePDF.vue
similarity index 86%
rename from ui/src/core_components/CorePDF.vue
rename to ui/src/core_components/embeds/CorePDF.vue
index f827cd626..e62cb4ebd 100644
--- a/ui/src/core_components/CorePDF.vue
+++ b/ui/src/core_components/embeds/CorePDF.vue
@@ -11,8 +11,8 @@
 </template>
 
 <script lang='ts'>
-import { FieldType } from "../streamsyncTypes";
-import { cssClasses } from "../renderer/sharedStyleFields";
+import { FieldType } from "../../streamsyncTypes";
+import { cssClasses } from "../../renderer/sharedStyleFields";
 
 const description =
 	"A component to embed a PDF document.";
@@ -36,12 +36,12 @@ export default {
 
 <script setup lang="ts">
 import { inject } from "vue";
-import injectionKeys from "../injectionKeys";
+import injectionKeys from "../../injectionKeys";
 const fields = inject(injectionKeys.evaluatedFields);
 </script>
 
 <style scoped>
-@import "../renderer/sharedStyles.css";
+@import "../../renderer/sharedStyles.css";
 .CorePDF {
   position: relative;
   width: 100%;

From 73109f62b67a9dac0f4a00a1f5ea2ecce15c52e1 Mon Sep 17 00:00:00 2001
From: Mateusz Russak <mateusz@russak.biz>
Date: Mon, 19 Feb 2024 14:28:43 +0100
Subject: [PATCH 2/2] fix: pdf drag and drop problems + review

---
 .../{embeds => embed}/CoreGoogleMaps.vue               |  2 +-
 .../core_components/{embeds => embed}/CoreIFrame.vue   |  6 +++++-
 ui/src/core_components/{embeds => embed}/CorePDF.vue   | 10 +++++++---
 3 files changed, 13 insertions(+), 5 deletions(-)
 rename ui/src/core_components/{embeds => embed}/CoreGoogleMaps.vue (99%)
 rename ui/src/core_components/{embeds => embed}/CoreIFrame.vue (94%)
 rename ui/src/core_components/{embeds => embed}/CorePDF.vue (83%)

diff --git a/ui/src/core_components/embeds/CoreGoogleMaps.vue b/ui/src/core_components/embed/CoreGoogleMaps.vue
similarity index 99%
rename from ui/src/core_components/embeds/CoreGoogleMaps.vue
rename to ui/src/core_components/embed/CoreGoogleMaps.vue
index 3f1d39a9c..0b50b944a 100644
--- a/ui/src/core_components/embeds/CoreGoogleMaps.vue
+++ b/ui/src/core_components/embed/CoreGoogleMaps.vue
@@ -204,7 +204,7 @@ watch(fields.mapId, initMap);
 }
 
 .CoreGoogleMaps.beingEdited .mask {
-  pointer-events: all;
+  pointer-events: auto;
   position: absolute;
   top: 0;
   left: 0;
diff --git a/ui/src/core_components/embeds/CoreIFrame.vue b/ui/src/core_components/embed/CoreIFrame.vue
similarity index 94%
rename from ui/src/core_components/embeds/CoreIFrame.vue
rename to ui/src/core_components/embed/CoreIFrame.vue
index 2e9935125..54d98ea2c 100644
--- a/ui/src/core_components/embeds/CoreIFrame.vue
+++ b/ui/src/core_components/embed/CoreIFrame.vue
@@ -68,6 +68,10 @@ function handleLoad() {
   height: 80vh;
 }
 
+.CoreIFrame.beingEdited:not(.selected) iframe {
+    pointer-events: none;
+}
+
 .CoreIFrame  iframe {
   width: 100%;
   height: 100%;
@@ -81,7 +85,7 @@ function handleLoad() {
 }
 
 .CoreIFrame.beingEdited .mask {
-  pointer-events: all;
+  pointer-events: auto;
   position: absolute;
   top: 0;
   left: 0;
diff --git a/ui/src/core_components/embeds/CorePDF.vue b/ui/src/core_components/embed/CorePDF.vue
similarity index 83%
rename from ui/src/core_components/embeds/CorePDF.vue
rename to ui/src/core_components/embed/CorePDF.vue
index e62cb4ebd..f5b32a30a 100644
--- a/ui/src/core_components/embeds/CorePDF.vue
+++ b/ui/src/core_components/embed/CorePDF.vue
@@ -1,8 +1,8 @@
 <template>
 	<div class="CorePDF">
-		<object class="pdf" :data="fields.source.value" type="application/pdf">
+		<object class="pdf" :data="fields.source.value" :key="fields.source.value" type="application/pdf">
 			<p>
-				You don't have a PDF plugin, but you can
+				You're not authorised to embed in the browser or you don't have PDF plugin
 				<a :href="fields.source.value">download the PDF file. </a>
 			</p>
 		</object>
@@ -48,6 +48,10 @@ const fields = inject(injectionKeys.evaluatedFields);
   height: 80vh;
 }
 
+.CorePDF.beingEdited:not(.selected) object {
+	pointer-events: none;
+}
+
 .CorePDF .pdf {
   width: 100%;
   height: 100%;
@@ -61,7 +65,7 @@ const fields = inject(injectionKeys.evaluatedFields);
 }
 
 .CorePDF.beingEdited .mask {
-  pointer-events: all;
+  pointer-events: auto;
   position: absolute;
   top: 0;
   left: 0;