New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent convention? #37

Open

codesman opened this issue Nov 1, 2016 · 0 comments

codesman commented Nov 1, 2016

Not really a problem per se, just noticed that this method doesn't follow the same naming convention as the other two registration methods.

Currently the generator outputs this:

/**
* Optional. If your extension creates a new field interaction or display template...
*/
public function register_fields($actions)
{
    $actions[ 'my-extension' ] = new NF_TourBundles_Fields_MyExtensionExample(); // includes/Fields/MyExtensionExample.php

    return $actions;
}

But looking at the other two methods, it seems like it should be:

/**
* Optional. If your extension creates a new field interaction or display template...
*/
public function register_fields($fields)
{
    $fields[ 'my-extension' ] = new NF_TourBundles_Fields_MyExtensionExample(); // includes/Fields/MyExtensionExample.php

    return $fields;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment