Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foonathan memory library is missing generated header #7412

Open
Gold856 opened this issue Nov 19, 2024 · 3 comments · May be fixed by #7421
Open

Foonathan memory library is missing generated header #7412

Gold856 opened this issue Nov 19, 2024 · 3 comments · May be fixed by #7421
Labels
type: bug Something isn't working.

Comments

@Gold856
Copy link
Contributor

Gold856 commented Nov 19, 2024

If you open up container_node_sizes.hpp, you'll notice that it includes container_node_sizes_impl.hpp. Looking at the foonathan memory repo, it appears this header is generated and might be machine specific. This header is needed to use any of the custom containers, and our build currently does not generate it. We should figure out how to get our Gradle build to generate this header.
@Gold856 Gold856 added the type: bug Something isn't working. label Nov 19, 2024
@Advay17
Copy link
Contributor

Advay17 commented Nov 20, 2024 •
edited
Loading

It appears that it is generated using a cmake step:

if(NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/container_node_sizes_impl.hpp)
get_container_node_sizes(${CMAKE_CURRENT_BINARY_DIR}/container_node_sizes_impl.hpp)
endif()

From:here

I would assume that means we need to modify allwpilib/wpiutil/CMakeLists.txt

@PeterJohnson
Copy link
Member

That works for cmake, but we'll need to replicate the logic (or work around it, e.g. with ifdefs for our specific supported platforms) for other build systems (bazel, Gradle).

@Advay17
Copy link
Contributor

Advay17 commented Nov 21, 2024

I believe I have the cmake portion completed, in what folder should the generated file go?

@Advay17 Advay17 linked a pull request Nov 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Generation of Missing Header Advay17/allwpilib
3 participants
@PeterJohnson @Gold856 @Advay17