Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Generation of Missing Header #7421

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added Generation of Missing Header #7421

wants to merge 2 commits into from
+700 −0

Conversation

Advay17
Copy link
Contributor

@Advay17 Advay17 commented Nov 21, 2024

Will close #7412

@Advay17
Copy link
Contributor Author

Advay17 commented Nov 21, 2024

Still need to add gradle and bazel versions

calcmogul
calcmogul requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated file should be moved to wpiutil/src/generated so it doesn't get clobbered by the upstream_utils script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul requested changes

@PeterJohnson PeterJohnson Awaiting requested review from PeterJohnson PeterJohnson will be requested when the pull request is marked ready for review PeterJohnson is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Foonathan memory library is missing generated header
2 participants
@Advay17 @calcmogul