Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename wpi::CreateEvent and wpi::CreateSemaphore #7303

Open
ThadHouse opened this issue Oct 28, 2024 · 0 comments · May be fixed by #7336
Open

Rename wpi::CreateEvent and wpi::CreateSemaphore #7303

ThadHouse opened this issue Oct 28, 2024 · 0 comments · May be fixed by #7336
Labels
component: wpiutil WPI utility library type: fix Iterations on existing features or infrastructure.

Comments

@ThadHouse
Copy link
Member

CreateEvent and CreateSemaphore are those special windows names that are macroed between A and W. This makes header ordering a requirement, which is kind of a pain. We've avoided most of these in the library, this is probably just 1 more to do.
@rzblue rzblue added the component: wpiutil WPI utility library label Nov 3, 2024
@spacey-sooty spacey-sooty linked a pull request Nov 4, 2024 that will close this issue
Open
@calcmogul calcmogul added the type: fix Iterations on existing features or infrastructure. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: wpiutil WPI utility library type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wpiutil] Rename create event and semaphore spacey-sooty/allwpilib
3 participants
@calcmogul @ThadHouse @rzblue