You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe. edu.wpi.first.wpilibj.sysid.SysIdRoutineLog.MotorLog.angularPosition,
public MotorLog angularPosition(Measure<Angle> position) {
return value("position", position.in(Rotations), Rotations.name());
}
angularPosition() method takes a Measure as an input, but logs only rotations. There's no other overloads, making it impossible to log radians without using an inaccurate Measure.
Describe the solution you'd like
An overload to select the unit type: public MotorLog angularPosition(Measure<Angle> position, Angle unit)
Additionally, documentation that the current method defaults to rotations
Describe alternatives you've considered
An overload without measures: public MotorLog angularPosition(double position, String unit), though it's similar to just using public MotorLog value(String name, double value, String unit)
Coordination in the SysID application Data Selector that allows users to select what units are used, potentially using the unit name in MotorLog. Related to #6284
Additional context
All of the above should be for all MotorLog unit methods (e.g., voltage(), linearPosition, angularVelocity, etc.), I simply used angularPosition as an example.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
edu.wpi.first.wpilibj.sysid.SysIdRoutineLog.MotorLog.angularPosition
,angularPosition() method takes a Measure as an input, but logs only rotations. There's no other overloads, making it impossible to log radians without using an inaccurate Measure.
Describe the solution you'd like
An overload to select the unit type:
public MotorLog angularPosition(Measure<Angle> position, Angle unit)
Additionally, documentation that the current method defaults to rotations
Describe alternatives you've considered
An overload without measures:
public MotorLog angularPosition(double position, String unit)
, though it's similar to just usingpublic MotorLog value(String name, double value, String unit)
Coordination in the SysID application Data Selector that allows users to select what units are used, potentially using the unit name in MotorLog. Related to #6284
Additional context
All of the above should be for all MotorLog unit methods (e.g., voltage(), linearPosition, angularVelocity, etc.), I simply used angularPosition as an example.
The text was updated successfully, but these errors were encountered: