Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools scripts copies broken on cross builds #436

Closed
sciencewhiz opened this issue Sep 29, 2024 · 1 comment
Closed

Tools scripts copies broken on cross builds #436

sciencewhiz opened this issue Sep 29, 2024 · 1 comment

Comments

@sciencewhiz
Copy link
Contributor

#433, #434, and #435 use the current OS to determine which scripts to copy. This works in CI since we build each version on the appropriate OS. However, the installer supports cross platform building, so this doesn't work in that case.

Perhaps a better solution would be to test if the files exist, and then do the copy if they do, since scripts/tools.gradle does work properly for cross builds and only makes available the right files.

@rzblue
Copy link
Member

rzblue commented Sep 29, 2024

ToolsUpdater is run during install, not build, so that behavior is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants