Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy folder deploys as admin #408

Open
ThadHouse opened this issue Feb 28, 2020 · 1 comment · May be fixed by #740
Open

Deploy folder deploys as admin #408

ThadHouse opened this issue Feb 28, 2020 · 1 comment · May be fixed by #740

Comments

@ThadHouse
Copy link
Member

This causes user code to not be able to overwrite deployed files.

https://www.chiefdelphi.com/t/writing-to-a-json-file/379567/2
@Starlight220
Copy link
Member

Starlight220 commented Nov 18, 2020 •
edited
Loading

So we want the /deploy/ folder to be deployed as lvuser? And does the rest of the deploy need to be as admin?

From what I understand, the deploying user is set as admin here:

GradleRIO/src/main/groovy/edu/wpi/first/gradlerio/frc/RoboRIO.groovy

Line 59 in 6646f69

ds.setUser("admin")

Code is run on the RIO as lvuser.

We either change the whole deploy to be done as lvuser (in the linked line above) or split into two deploys: deploying the code as admin and deploying the /deploy/ folder as lvuser. I believe that the former is better. @ThadHouse - what are your thoughts?

spacey-sooty added a commit to spacey-sooty/GradleRIO that referenced this issue Jun 5, 2024
@spacey-sooty
Deploy files as lvuser not admin
7f26851 
Resolves wpilibsuite#408
@spacey-sooty spacey-sooty linked a pull request Jun 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deploy files as lvuser not admin spacey-sooty/GradleRIO
2 participants
@ThadHouse @Starlight220