Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo embed error #57

Closed
silversillu opened this issue Jun 21, 2018 · 4 comments
Closed

Vimeo embed error #57

silversillu opened this issue Jun 21, 2018 · 4 comments
Assignees

Comments

@silversillu
Copy link

When embedding a video from Vimeo using [embed] shortcode, the following happens:

<iframe> has no src attribute.
screenshot

Vimeo's Javascript can't read the src attribute.
screenshot 2

This specific video is hidden during the page load which might be causing the issue.

Managed to fix this with a workaround by using <iframe> with data-no-lazy="1" instead of [embed].

Original code: [embed width=1000 height=562]https://player.vimeo.com/video/xxxxxxxxx[/embed]

cc @lkraav

@remyperona remyperona self-assigned this Jul 3, 2018
@remyperona
Copy link
Contributor

It's probably not specific to Vimeo, but because the iframe is initially hidden, so it's not detected by the lazyload script.

Which browser(s) did you test on?

@lkraav
Copy link

lkraav commented Jul 3, 2018

Which browser(s) did you test on?

AFAICT it's the same on all browsers. EDIT how could it not be?

@lkraav
Copy link

lkraav commented Jul 31, 2018

@silversillu couple of minor updates have been deployed. Can you check if anything has improved with this?

@silversillu
Copy link
Author

@lkraav fixed! iframes have the src attribute available on page load now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants