Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error from League Container conflict with WooCommerce 4.4 #116

Closed
hellofromtonya opened this issue Aug 18, 2020 · 0 comments · Fixed by #117
Closed

Fatal error from League Container conflict with WooCommerce 4.4 #116

hellofromtonya opened this issue Aug 18, 2020 · 0 comments · Fixed by #117
Assignees
Labels

Comments

@hellofromtonya
Copy link

A customer has reported a fatal error when upgrading to WooCommerce 4.4 version.

As Daniel points out here, we include the composer packages with the plugin and load the composer autoload file. That puts the original package PSR4 namespaces into memory.

Though our plugin doesn’t use them, as we have the dependencies in src/Dependencies with different namespaces, the original Container package can be called through this plugin when:

  1. This plugin loads first (which it does).
  2. And then WooCommerce plugin loads.

Fatal error.

engahmeds3ed added a commit that referenced this issue Aug 19, 2020
…merce 4.4 (PR #117)

* update composer.json to require league container on dev, update mozart and adjust composer scripts
* running composer install to let mozar get dependencies
* adjust travis to remove mozart before install
* adjust travis to use --no-scripts when using composer install
* add --no-scripts when removing mozart package for travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants