Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDN friendlyness #111

Open
szepeviktor opened this issue Mar 11, 2020 · 1 comment
Open

CDN friendlyness #111

szepeviktor opened this issue Mar 11, 2020 · 1 comment
Labels
bug

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 11, 2020 •
edited
Loading

Hello!

ROCKET_LL_ASSETS_URL etc. URL-s are defined very early: thus CDN MU/plugins are not able to alter the URL of e.g. lazyload.min.js

Please use core functions (plugins_url, content_url) at the time of outputting the script tag.
Thank you.
@remyperona
Copy link
Contributor

Hi,

We're going to move away from constants like this at some point, so it will be something we're going to fix at the same time :)

@remyperona remyperona added the bug label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @remyperona