-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility issue after WordPress 6.4 with the new lightbox functionality #758
Comments
It can be seen here: |
Root causeThe root cause is that we are adding the attributes on both the Scope a solutionA simple solution would be to filter out WordPress attributes for the picture tag in $p_attributes = array_filter($attributes, function ($attribute) {
return ! str_contains($attribute, 'data-wp');
}, ARRAY_FILTER_USE_KEY);
$output = '<picture' . $this->build_attributes( $p_attributes ) . ">\n"; Estimate effortEffort |
Looks good to me. |
@MathieuLamiot @engahmeds3ed is checking how the interactivity package is working inside Guttenberg as adding a callback to the lightbox doesn't seems to be attached to the context |
There is a progress there in Gutenberg for this issue, they opened a new PR to solve that: I'll test it with this PR but I believe it'd work, hope they release it soon. |
@piotrbak Gutenberg 17.4 is not released yet (RC01 ongoing). Should this issue be delayed to Imagify 2.1.5 then? |
@MathieuLamiot @CrochetFeve0251 Just to confirm, when Gutenberg releases the enhancement, will it fix the issue automatically or it'll allow us to fix it on our end? |
We still need this PR to be merged to add the attributes to pictures. |
So this is still an issue today? |
Yes it is :) |
@rfischmann @soloman981 |
Describe the bug
When the "Display images in WebP format on the site” option is turned on as
To Reproduce
Steps to reproduce the behavior:
Additional context
Tickets from HS and WordPress.org
https://secure.helpscout.net/conversation/2416490954/453777/
https://wordpress.org/support/topic/imagify-conflicts-with-wordpress-6-4s-new-lightbox-functionality/
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: