Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 6.3 Image Features #739

Open
michaelbourne opened this issue Aug 1, 2023 · 1 comment
Open

WordPress 6.3 Image Features #739

michaelbourne opened this issue Aug 1, 2023 · 1 comment
Labels
needs: grooming priority: medium Issues which are important, but no one will go out of business. type: enhancement

Comments

@michaelbourne
Copy link
Contributor

michaelbourne commented Aug 1, 2023

Describe the bug
WordPress 6.3 adds a new fetchpriority attribute as well as aspect ratio controls in Image blocks. As of now, aspect ratio is controlled via inline css on the img tag itself, so it needs to be checked for when creating the picture tag.

Likewise, both the fetchpriority and decoding attributes need to be left on the img tag and not moved to the picture tag.

To Reproduce
Steps to reproduce the behavior:

  1. Install WP 6.3
  2. Set an aspect ratio on an image block in Gutenberg.
  3. Add a large image in Gutenberg to trigger the fetchpriority attribute.
  4. Save post. View on front end, inspect the image block. You will see the aspect ratio doesn't work as it has been moved to the picture tag. You will also see the other two attributes moved from the img to the picture tag.

Expected behavior
All 3 elements need to remain in the img tag.

Additional context
PR #738 created to fix.

@michaelbourne
Copy link
Contributor Author

Can I get an update on this? While minor, this is a breaking change in WordPress 6.3 and needs to be addressed by this plugin.

@piotrbak piotrbak added type: enhancement needs: grooming priority: medium Issues which are important, but no one will go out of business. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: grooming priority: medium Issues which are important, but no one will go out of business. type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants