Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking of meta updates should be opt-in instead of opt-out #218

Open
jasonbahl opened this issue May 5, 2023 · 0 comments
Open

Tracking of meta updates should be opt-in instead of opt-out #218

jasonbahl opened this issue May 5, 2023 · 0 comments
Labels
compat: breaking change This is a breaking change to existing functionality type: enhancement Improvements to existing functionality

Comments

@jasonbahl
Copy link
Collaborator

Currently WPGraphQL Smart Cache listens for changes to meta, and triggers purge events for the node that was updated.

A lot of plugins update meta a lot more then it seems like they should leading to more purge requests than expected.

Instead of default behavior to listen to all meta changes, I think the default should be to not track meta and instead make it opt-in.

Users must provide meta key(s) or other criteria that should be met for meta to individually be tracked for purge events.

@jasonbahl jasonbahl self-assigned this May 5, 2023
@jasonbahl jasonbahl added the type: enhancement Improvements to existing functionality label May 5, 2023
@jasonbahl jasonbahl added the compat: breaking change This is a breaking change to existing functionality label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat: breaking change This is a breaking change to existing functionality type: enhancement Improvements to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant