Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other file extensions #191

Closed
1 task done
strarsis opened this issue Nov 1, 2019 · 2 comments
Closed
1 task done

Allow other file extensions #191

strarsis opened this issue Nov 1, 2019 · 2 comments

Comments

@strarsis
Copy link
Contributor

strarsis commented Nov 1, 2019

Feature Request

Describe your use case and the problem you are facing

make-pot should allow configurable extension for the files to scan.
E.g. when the theme uses the blade template language (like the roots.io Sage theme), many files will have the extension blade.php instead just php. Currently make-pot ignores these and the translations strings in the POT file are missing.

Describe the solution you'd like
A configuration option for the make-pot command for specifying different/more extension of the files to scan.

@strarsis
Copy link
Contributor Author

strarsis commented Feb 21, 2022

Actually for support of files with multiple file extensions (as blade.php for PHP-Blade files),
the IterableCodeExtractor filter has to be refactored, see this PR for PHP-Blade templates: #304

@swissspidy
Copy link
Member

swissspidy commented Mar 14, 2022

Closing this since dedicated Blade support was added in #304.

If it turns out that such configuration is needed for other file types, we can reopen it.

Edit: see also #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants