Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove language translation check from core update process #192

Closed
wants to merge 7,696 commits into from
Closed

Remove language translation check from core update process #192

wants to merge 7,696 commits into from

Conversation

bgturner
Copy link

@bgturner bgturner commented Sep 24, 2021 •
edited by swissspidy
Loading

Fixes #191

gitlost and others added 30 commits November 13, 2017 14:36
@gitlost
Merge pull request wp-cli#44 from wp-cli/43-skip-cache-http
956e11d 
Skip cache also when ZIP URL is 'http://' to nightly build
@gitlost
Update scaffolded tests to latest (enable error reporting).
9e30c57
@gitlost
Fix test breakages; avoid 4.9 email on skip; checksum request fail wa…
afce3b2 
…rnings.
@gitlost
Allow for nightly/trunk/old behaviour; improve checksum messages; cle…
8bf132c 
…aned -> cleaning typo.
@gitlost
Add back --skip-email in core.feature:304.
300cd92
@gitlost
Remove --skip-email from core.feature:304 again to see if sh: 1: -t e…
ca67921 
…rror.
@gitlost
Ok add back skip-email to core.feature:304 for the mo.
df017d2
@gitlost
Mark core.feature:304 broken and allow non-empty stderr.
c8c03b9
@gitlost
core.feature:304 failure was due to missing no-mail.php. Sigh.
04ec503
@gitlost
Fix tab.
7f8c832
@danielbachhuber
Merge pull request wp-cli#45 from wp-cli/update_tests_enable_error_re…
f302ad9 
…porting

Update tests enable error reporting
@danielbachhuber
Update scaffolded README and GitHub configuration
afbdde5 
* Regenerates README.md
* Adds `.github/settings.yml` for description and label management.
* Updates `.github/PULL_REQUEST_TEMPLATE`
@danielbachhuber
Update scaffolded README too
50f524c
@gitlost
Ignore SSL trigger_error in WP get_core_checksums() on core upgrade.
7caedf9
@gitlost
Use restore_error_handler for PHP < 5.5 compat.
99a92e5
@danielbachhuber
Merge pull request wp-cli#48 from wp-cli/upgrade_set_error_handler
1268214 
Ignore SSL trigger_error in WP get_core_checksums() on core upgrade.
@gitlost
Merge remote-tracking branch 'upstream/master' into scaffold-readme-g…
8b8b0f4 
…ithub-11-20
@gitlost
Remove hints from CoreUpgrader::error_handler.
fb35bdc
@danielbachhuber
Merge pull request wp-cli#47 from wp-cli/scaffold-readme-github-11-20
6662f25 
Update scaffolded README and GitHub configuration
@DrewAPicture
Use third-person singular verbs in the summary for the core command.
21273c0
@DrewAPicture
Convert core subcommand help summaries (and other method DocBlock sum…
6d083c4 
…maries) to use third-person singular verbs.
@danielbachhuber
Regenerate README from command description
5d4fa0d
@danielbachhuber
Merge pull request wp-cli#53 from DrewAPicture/issue/doc-verbs
a1dff53 
Convert core command help summaries to use third-person singular verbs.
@danielbachhuber
Fix GitHub label generation
d9e840e
@gitlost
3rd-person-singularize the description.
dc0df87
@grantpalin
Replace "install" with "installation" where appropriate
39838ea
@gitlost
Merge pull request wp-cli#54 from wp-cli/fix-github-labels
60cb730 
Fix GitHub label generation
@miya0001
Merge pull request wp-cli#55 from grantpalin/install-installation
34a7cc4 
Replace "install" with "installation" where appropriate
@danielbachhuber
Convert 'install' -> 'installation' in all the correct places
c777a1c
@gitlost
Merge pull request wp-cli#56 from wp-cli/55-update-installation
9044a7f 
Convert 'install' -> 'installation' in all the correct places
wojsmol and others added 19 commits May 4, 2021 20:08
@wojsmol
Move wp-cli/wp-cli-tests to dev dependecies and update
6e1f47c
@schlessera
Merge pull request wp-cli#185 from wojsmol/tests-to-dev
23184b3 
Move wp-cli/wp-cli-tests to dev dependecies and update
@schlessera
Add --insecure flag to core download & core update command
7249cff
@schlessera
Add $insecure argument to CoreUpgrader class
4adf955
@schlessera
Update file(s) from wp-cli/.github
52f5df8
@schlessera
Update file(s) from wp-cli/.github
55f1d57
@schlessera
Regenerate README file - 2021-05-10
d3ac993
@schlessera
Merge pull request wp-cli#188 from wp-cli/regenerate-readme
12bcc24
@schlessera
Use WpOrgApi abstraction
9d600a7
@schlessera
Use array access into offer
c1b1187
@schlessera
Merge pull request wp-cli#186 from wp-cli/fix/disable-http-request-re…
cc32c8a 
…try-by-default
@schlessera
Regenerate README file - 2021-05-10
d5707e4
@schlessera
Merge pull request wp-cli#189 from wp-cli/regenerate-readme
b7f44f0 
Regenerate README file
@schlessera
Update file(s) from wp-cli/.github
2435f99
@schlessera
Update file(s) from wp-cli/.github
0b8b8f5
@schlessera
Update file(s) from wp-cli/.github
9ba7d1a
@schlessera
Update file(s) from wp-cli/.github
b366a56
@schlessera
Update file(s) from wp-cli/.github
7811e3e
@bgturner
Remove language translation check from core upgrade process
2cf1da4
@bgturner bgturner requested a review from a team as a code owner September 24, 2021 17:20
@bgturner
Copy link
Author

This does prevent the markup and error within the terminal, but one apparent consequence is that the user needs to manually update translations, for example with the wp language subcommand. Is that still intended behavior, or should the core updater also queue the updates for the language translations?

@swissspidy swissspidy changed the title fix: #191 Remove language translation check from core update process Remove language translation check from core update process Sep 24, 2021
@schlessera
Copy link
Member

The general philosophy of WP-CLI is that commands should only solve one single unique problem (i.e. updating core). It makes sense that the languages need to be updated separately via CLI.

@schlessera
Copy link
Member

This will still need a test to ensure the language installation is reliably disabled across all WP versions.

Let me know if you need help getting started with Behat testing.

(I'll also have to figure out what the current test failures are about.)

@schlessera
Copy link
Member

@bgturner Are you still up for working on this and implement the needed test?

@bgturner
Copy link
Author

Sorry for dropping this. I've been pulled to other things. If someone else wants to take this initial work and run with it, I'd be happy for it to be solved.

Otherwise, I can probably circle around later in August

@danielbachhuber
Copy link
Member

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/d61dbf890608fe24eb2ab2ed526f438a in case this PR is auto-closed or broken in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
command:core-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected HTML output when updating WordPress