Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checksum verification of must-use plugins #27

Open
schlessera opened this issue Dec 22, 2017 · 3 comments
Open

Add support for checksum verification of must-use plugins #27

schlessera opened this issue Dec 22, 2017 · 3 comments

Comments

@schlessera
Copy link
Member

schlessera commented Dec 22, 2017

As discussed in #26 (comment) , the plugin checksum verification currently ignores must-use plugins.

Should these be checked by default? ... or only through an additional flag?

I think I'd prefer to have them be included in the checks by default, with a flag to omit them if they should cause trouble.

@szepeviktor
Copy link
Contributor

Where would checksums of MU plugins come from?

@schlessera
Copy link
Member Author

The plugin header file can be checked to retrieve the plugin slug.

This works well for normal plugins that were moved into the mu-plugins folder and an MU-loader system like the one from Bedrock or WP-Starter takes care of actually loading them.

It won't work so well for:

  1. Individual plugin files that were put there just to trigger the loading of a subfolder plugin.
  2. Individual plugin files that contain custom logic for that site.

For now, we should throw warnings when 1. or 2. are found, as erroring out would make MU-plugins mostly unusable in terms of checksum verification.

@szepeviktor
Copy link
Contributor

I solve a lot of problems in single-file MU plugins.
At least 10 MU-s are installed per site.

It would be great to have checksums in a list like

mu-file-name.php<TAB>hash-hash-hash

owned by root and having 0644 permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants