Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Database Config From Setup Process #28

Open
alpipego opened this issue Jun 3, 2018 · 3 comments
Open

Remove Database Config From Setup Process #28

alpipego opened this issue Jun 3, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@alpipego
Copy link
Member

alpipego commented Jun 3, 2018

In general, the included SQLite database should be used in development as it makes it easier for users to see content directly after setup (e.g., if they're not willing/able to set up their own GitHub app).

If a user wants to use their DB, they'll still be able to do it by changing the config file manually.

@alpipego alpipego added the enhancement New feature or request label Jun 3, 2018
@alpipego alpipego assigned alpipego and unassigned alpipego Jun 3, 2018
@alpipego
Copy link
Member Author

alpipego commented Jun 3, 2018

@hofmannsven I prefer this over adding the password to the setup process.

@alpipego
Copy link
Member Author

alpipego commented Jun 3, 2018

For the password-protected database, please follow-up in #29

@hofmannsven
Copy link
Collaborator

I think we can remove the database config from the setup process as the default setup with SQLite works just fine.
Let's keep the setup as simple and short as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants