Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Manifest #16

Open
barncastle opened this issue Mar 15, 2021 · 0 comments
Open

Install Manifest #16

barncastle opened this issue Mar 15, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@barncastle
Copy link
Collaborator

Identified two issues:

  1. Blizzard now has duplicate entries in the Install manifest however I'm not sure if this is a bug their end or not. I assume that all identical files should be merged and have the correct tags set. This has been seen on BlizzardError.exe for x64 and arm64. If this is not a bug then this need supporting which leads onto issue 2...

  2. Currently Install file entries are stored in a Dictionary with the filename as key, this was done for speed of searching by filename. However there may be a situation where multiple versions of the same named file exist (more likely with Win ARM support now), which at present, only the first entry is stored. This needs to be converted to either a multimap, a list or stored by CKey instead then methods updated accordingly.
@barncastle barncastle added the help wanted Extra attention is needed label Mar 15, 2021
barncastle added a commit that referenced this issue Mar 15, 2021
@barncastle
issue #16 allowing multiple entries for different platforms
1e9a836 
also added some helper methods
@barncastle barncastle mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barncastle