From 6128e2fa5da563533491597944b8bfbb34252030 Mon Sep 17 00:00:00 2001
From: Wojciech Zmuda <zmuda.w@gmail.com>
Date: Fri, 23 Aug 2024 00:54:50 +0200
Subject: [PATCH] 4844 tests to dedicated contract:
 testRegisterIdentitiesWithRunsOfZeroes

---
 ...ntityManagerIdentityRegistration4844.t.sol | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol b/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
index 47edf39..596a1f8 100644
--- a/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
+++ b/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
@@ -568,4 +568,57 @@ contract WorldIDIdentityManagerIdentityRegistration4844 is WorldIDIdentityManage
         // Test
         assertCallFailsOn(identityManagerAddress, callData, expectedError);
     }
+
+    /// @notice Tests that runs of zeroes are accepted by the `registerIdentities` function as valid
+    ///         arrays of identity commitments.
+    function testRegisterIdentitiesWithRunsOfZeroes(uint8 identitiesLength, uint8 zeroPosition)
+    public
+    {
+        // Setup
+        vm.assume(identitiesLength != 0 && identitiesLength <= 1000);
+        vm.assume(zeroPosition < identitiesLength && zeroPosition > 0);
+        uint256[] memory identities = new uint256[](identitiesLength);
+        (
+            VerifierLookupTable insertVerifiers,
+            VerifierLookupTable deletionVerifiers,
+            VerifierLookupTable updateVerifiers
+        ) = makeVerifierLookupTables(TC.makeDynArray([identitiesLength]));
+        makeNewIdentityManager(
+            treeDepth,
+            initialRoot,
+            insertVerifiers,
+            deletionVerifiers,
+            updateVerifiers,
+            semaphoreVerifier
+        );
+
+        for (uint256 i = 0; i < zeroPosition; ++i) {
+            identities[i] = i + 1;
+        }
+        for (uint256 i = zeroPosition; i < identitiesLength; ++i) {
+            identities[i] = 0x0;
+        }
+
+        ManagerImplV3.RegisterIdentities4844Params memory params = ManagerImplV3.RegisterIdentities4844Params({
+            insertionProof: [uint256(2), 1, 3, 4, 5, 6, 7, 9],
+            commitments: commitments,
+            commitmentPok: commitmentsPok,
+            kzgCommitment: kzgCommitment,
+            kzgProof: kzgProof,
+            expectedEvaluation: insertionExpectedEvaluation,
+            preRoot: initialRoot,
+            postRoot: insertionPostRoot,
+            kzgChallenge: kzgChallenge,
+            inputHash: insertionInputHash4844,
+            batchSize: uint32(identities.length),
+            startIndex: startIndex
+        });
+
+        // Mock blobhash. This is valid for the next call only.
+        prepareBlobhash(kzgToVersionedHash(kzgCommitment));
+        bytes memory callData = abi.encodeCall(ManagerImplV3.registerIdentities, params);
+
+        // Test
+        assertCallSucceedsOn(identityManagerAddress, callData, new bytes(0));
+    }
 }