From 21fafe7bb6e6f74e2253e38b5152e62e865930f7 Mon Sep 17 00:00:00 2001
From: Wojciech Zmuda <zmuda.w@gmail.com>
Date: Fri, 23 Aug 2024 00:51:57 +0200
Subject: [PATCH] 4844 tests to dedicated contract:
 testCannotRegisterIdentitiesWithOutdatedRoot

---
 ...ntityManagerIdentityRegistration4844.t.sol | 47 +++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol b/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
index fcf0ad1..47edf39 100644
--- a/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
+++ b/src/test/identity-manager/WorldIDIdentityManagerIdentityRegistration4844.t.sol
@@ -521,4 +521,51 @@ contract WorldIDIdentityManagerIdentityRegistration4844 is WorldIDIdentityManage
         // Test
         assertCallFailsOn(identityManagerAddress, callData, errorData);
     }
+
+    /// @notice Tests that it reverts if an attempt is made to register identities with an outdated
+    ///         root.
+    function testCannotRegisterIdentitiesWithOutdatedRoot(
+        uint256 currentPreRoot,
+        uint256 actualRoot
+    ) public {
+        // Setup
+        vm.assume(
+            currentPreRoot != actualRoot && currentPreRoot < SNARK_SCALAR_FIELD
+            && actualRoot < SNARK_SCALAR_FIELD
+        );
+        makeNewIdentityManager(
+            treeDepth,
+            uint256(currentPreRoot),
+            defaultInsertVerifiers,
+            defaultDeletionVerifiers,
+            defaultUpdateVerifiers,
+            semaphoreVerifier
+        );
+
+        ManagerImplV3.RegisterIdentities4844Params memory params = ManagerImplV3.RegisterIdentities4844Params({
+            insertionProof: insertionProof,
+            commitments: commitments,
+            commitmentPok: commitmentsPok,
+            kzgCommitment: kzgCommitment,
+            kzgProof: kzgProof,
+            expectedEvaluation: insertionExpectedEvaluation,
+            preRoot: actualRoot,
+            postRoot: insertionPostRoot,
+            kzgChallenge: kzgChallenge,
+            inputHash: insertionInputHash4844,
+            batchSize: uint32(identityCommitments.length),
+            startIndex: startIndex
+        });
+
+        // Mock blobhash. This is valid for the next call only.
+        prepareBlobhash(kzgToVersionedHash(kzgCommitment));
+        bytes memory callData = abi.encodeCall(ManagerImplV3.registerIdentities, params);
+
+        bytes memory expectedError = abi.encodeWithSelector(
+            ManagerImplV1.NotLatestRoot.selector, actualRoot, uint256(currentPreRoot)
+        );
+
+        // Test
+        assertCallFailsOn(identityManagerAddress, callData, expectedError);
+    }
 }