Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_with_initial_values and attempt_restore are unsafe #51

Open
Dzejkop opened this issue Jun 28, 2023 · 0 comments
Open

new_with_initial_values and attempt_restore are unsafe #51

Dzejkop opened this issue Jun 28, 2023 · 0 comments

Comments

@Dzejkop
Copy link
Contributor

Dzejkop commented Jun 28, 2023

Not a big concern, since we never have other processes using the mmapped file, but the safety requirements of MmapOptions::with_file demand that we have exclusive mutable access to the file.

We should add file locking using a crate like fd-lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant