-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows for creating releases #6365
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love seeing some automation.
Have you considered adding to the already existing Buildkite setup?
Thanks @mokagio !
I have. This is in part a POC since I don't have much access on Buildkite to try stuff out. I do think it's convenient to have the But as I mentioned it would be nice to trigger the automation from the the Github Workflow since it can be started remotely. Since our current architecture required pushing changes to Gutenberg, it makes sense to do that and then trigger the workflow after that local script runs. Open to other options but this seems like a good option for now at least. The |
@jhnstn gotcha.
Was is it that is convenient? Starting the workflow remotely/from GitHub? If that's the case, Buildkite pipelines can be started remotely, too. We do that, for example, in WordPress iOS to run beta and release builds. I didn't run a comparison to know which provider would be faster, but having all our automation under the same provider would definitely be beneficial. For a start, it's one place to check. But most importantly, all our Buildkite CI infra is managed via Terraform and has various layers of safety, user management, and secrets management. |
Thanks @mokagio
I might had been a bit vague when I said "remotely". I specifically meant from the release wranglers local machine. That's the advantage I see with using a Github workflow. We can use everyone's Github PAT to trigger the workflow. Beyond that I don't have an opinion on where the job actually runs.
Totally get this. And I think we should fold the |
Anyways, once, soon, we'll have our GUI to manage releases, all the storing of token and triggering of automation will live there |
This adds two Github workflows to create release PRs
prepare-release.yml
will create a release PR on this repo, Gutenberg Mobileintegrate-release.yml
will create an integration release on the specified platformBoth take a release version and the option to specify a
gbm-cli
version (this can be a tag or a commit onrelease-toolkit-gutenberg-mobile
)As-is we will need to generate an access token and add it to this repository. There is a
PAT_TOKEN
there now but I'm not sure if it's still valid. We need a secret named 'GH_ACCESS_TOKEN` that has access to this repo for the prepare commands. The token will have to work with the main app repos for the integration workflow to work.To test:
Testing will get a bit noisy so it might be best to merge this branch into a fork of Gutenberg Mobile and add
GBM_WPMOBILE_ORG
andGBM_WORDPRESS_ORG:
to the workflowenv
sections like so:You will also need a github PAT added to the fork as a repository secret named
GH_ACCESS_TOKEN
Then run the prepare worklfow with a version associated with a test release pr on your forked Gutenberg repo
The integration will only work for android in this scenario since iOS will require pods for the release.
PR submission checklist: