From 0b64235979a2f2750bfad0fc610658472fa19c07 Mon Sep 17 00:00:00 2001 From: Tony Li Date: Wed, 21 Feb 2024 14:36:57 +1300 Subject: [PATCH] Use more strict assertions --- .../WordPressComRestApiTests+Locale.swift | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/WordPressKitTests/WordPressComRestApiTests+Locale.swift b/WordPressKitTests/WordPressComRestApiTests+Locale.swift index 66643c3e..a37973ae 100644 --- a/WordPressKitTests/WordPressComRestApiTests+Locale.swift +++ b/WordPressKitTests/WordPressComRestApiTests+Locale.swift @@ -18,10 +18,10 @@ extension WordPressComRestApiTests { let _ = await api.perform(.get, URLString: "/path/path") let preferredLanguageIdentifier = WordPressComLanguageDatabase().deviceLanguage.slug - try XCTAssertTrue(XCTUnwrap(request?.url?.query).contains("locale=\(preferredLanguageIdentifier)")) + XCTAssertEqual(request?.url?.query, "locale=\(preferredLanguageIdentifier)") } - func testThatAppendingLocaleWorksWithExistingParams() async { + func testThatAppendingLocaleWorksWithExistingParams() async throws { var request: URLRequest? stub(condition: { _ in true }, response: { request = $0 @@ -37,8 +37,8 @@ extension WordPressComRestApiTests { let _ = await api.perform(.get, URLString: path, parameters: params) let preferredLanguageIdentifier = WordPressComLanguageDatabase().deviceLanguage.slug - try XCTAssertTrue(XCTUnwrap(request?.url?.query).contains("locale=\(preferredLanguageIdentifier)")) - try XCTAssertTrue(XCTUnwrap(request?.url?.query).contains("someKey=value")) + let query = try XCTUnwrap(request?.url?.query?.split(separator: "&")) + XCTAssertEqual(Set(query), Set(["locale=\(preferredLanguageIdentifier)", "someKey=value"])) } func testThatLocaleIsNotAppendedIfAlreadyIncludedInPath() async { @@ -91,7 +91,8 @@ extension WordPressComRestApiTests { let api = WordPressComRestApi(localeKey: "foo") + let preferredLanguageIdentifier = WordPressComLanguageDatabase().deviceLanguage.slug let _ = await api.perform(.get, URLString: "/path/path") - try XCTAssertTrue(XCTUnwrap(request?.url?.query).contains("foo=")) + XCTAssertEqual(request?.url?.query, "foo=\(preferredLanguageIdentifier)") } }