-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* feat: 킬링파트 듣기 스와이프시 songId를 통한 url 변경 * fix: Home과 Login 링크로 가지지 않는 버그 수정 - 버그 원인은 해당 링크로 이동시 모든 refCallback(createPlayerOnObserve)이 실행됨 - YoutubeIframe에 ref로 넘겨서 임시적으로 해결하였는데 정확한 원인은 분석하지 못함 * feat: 킬링파트 공유 버튼 클릭시 현재 페이지 링크 복사 * fix: Youtube 컴포넌트에서 url을 바꾸던 것을 SongDetailItem으로 이동 - PartCollectingPage에서도 동작하는 버그 수정 - YoutubeIframe에 ref가 걸려있어서 위로 올라갈때 감지되지 않는 버그 수정 * refactor: url에 useParams와 ROUTH_PATH를 활용하도록 변경 * refactor: useValidParams로 변경 * refactor: url을 변경하는 ref 태그를 최대한 아래쪽에 배치 * refactor: preventScrollReset 삭제
- Loading branch information
1 parent
dd71358
commit 790da5f
Showing
3 changed files
with
34 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters