Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 이미 환불된 거래 내역에 대한 예외 처리 단순화 #185

Open
yudonggeun opened this issue Aug 15, 2024 · 0 comments
Open

[REFACTOR] 이미 환불된 거래 내역에 대한 예외 처리 단순화 #185

yudonggeun opened this issue Aug 15, 2024 · 0 comments
Labels
REFACTOR 코드 개선

Comments

@yudonggeun
Copy link
Contributor 

          좋은 의견입니다! 사실 '거래 내역' 입장에서는 자신의 상태가 `환불됨` -> `환불됨` 으로 변경된다고 해서 예외로 인식하지 않아도 될 것 같아요!

하지만 해당 로직이 PaymentService에서 사용되던 것을 BidHistory 내부로 이전한 것이라, PaymentService와 PaymentServiceTest 등에도 영향이 있어, 별도의 태스크를 생성하고 그곳에서 처리하는 것이 좋을 것 같습니다..!!

Originally posted by @chhs2131 in #178 (comment)
@yudonggeun yudonggeun added the REFACTOR 코드 개선 label Aug 15, 2024
@yudonggeun yudonggeun mentioned this issue Aug 15, 2024
Merged
@chhs2131 chhs2131 changed the title [REFACTOR] TODO [REFACTOR] 이미 환불된 거래 내역에 대한 예외 처리 단순화 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
REFACTOR 코드 개선
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yudonggeun