-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work on brave-browser #98
Comments
Thanks for the report! Which native client are you using, and are you using any special arguments / MPV profiles with it? |
Hi, thanks for the reply. I am not sure what you meant by native client. It is pretty much stock brave-browser. My mpv config is pretty basic
|
Hi, I found out the reason that it wasn't working is that chromium based browsers include their own libvulkan which is broken. It is not clear from that thread why running mpv would invoke chrome's libvulkan (in my case mpv works fine except through brave with ff2mpv), but the error message is the same. I fixed it with a wrapper script for mpv like in one of the anwers
Now ff2mpv works for both brave and firefox. Instead of using the wrapper, can this be done by editing ff2mpv.py? |
Thanks for root-causing. My guess there is that the
The native client is the thing named either So yes, this can be done by editing |
Same issue with Brave on Fedora 39. @beew How do I make this wrapper script work and where do I put it? Both this and Thann/play-with-mpv are broken. |
Hi, I posted the script above. Name it mpv, make it executable and place it in a directory in your $PATH that overrides /usr/bin. This way when you invoke mpv say by typing mpv in the terminal it runs the script instead of /usr/bin/mpv In Ubuntu you can put the script in either ~/bin or ~/.local/bin. I am not sure about Fedora, you may need to add the path to your .profile or .bashrc then logout and login if it is not already there. /usr/local/bin is fine too but that needs sudo and I think Fedora doesn't respect /usr/local. my .profile looks like this
See "set Path so it includes user's private bin if exists". If they don't exist create them then logout and login for it to take effect |
I found a way to make the other extension work (Thann/play-with-mpv) but thanks anyway. |
I used to use that one but I switched because it spawned some zombie processes after playing the video. Check with top. |
This is an independent manifestation of #109. It looks like both Chrome-type browsers and Firefox have this problem, albeit with different interfering libraries. I have no good ideas for a fix here, other than doing some additional process isolation when spawning |
Closing in favor of continued tracking on #109. |
I have no problem with Firefox. But I grabbed firefox from Mozilla (tarball) to avoid snap. Not sure how they installed it. |
Yeah, I suspect that this is some of the problem. I also avoid the snap-ified Firefox and haven't had problems. |
Yes, just add it as an argument, something like:
|
When click the ff2mpv icon nothing happens
start brave from the terminal, go to Youtube and click the ff2mpv icon, got these error messages
OS is Ubuntu 22.04
Brave version 1.48.171 (based on Chromium 110.0.5481.177 )
mpv version
addition info
mpv works on local video, streaming through command line and ff2mpv works on firefox.
I have disabled brave's adblocker and re-eanbled it. Still doesn't work
this mpv addon does work for brave
https://chrome.google.com/webstore/detail/play-with-mpv/hahklcmnfgffdlchjigehabfbiigleji
The text was updated successfully, but these errors were encountered: