Replies: 2 comments 1 reply
-
The length comes from the fact that 3 or more chars words are pretty unique in texts already. Using a 1 char secret is fine for WP, but hiding it in logs makes no sense as you would already now which char it is from reading a log like this and IMO it just looks pretty weird as well: |
Beta Was this translation helpful? Give feedback.
1 reply
-
@xoxys Do you still think it should be reverted or can we close this? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@woodpecker-ci/maintainers I'm a bit confused about this decision made in #2680, and I would like to discuss it:
<=3
? Is there any resilient basis that secrets with<=3
chars are weak in terms of entropy? Secrets with<=4
chars are not weak anymore? This sounds a bit random to me.I would vote for reverting this PR and sanitize all secrets regardless of their length. I came across this while working on #3171 (comment) where I tried so understand some "magic numbers".
Beta Was this translation helpful? Give feedback.
All reactions