Server / Forges / Use string type for PullRequest as ForgeRemoteID instead of int64 #2746
Closed
mzampetakis
started this conversation in
General
Replies: 2 comments 1 reply
-
I see your point and I would be fine with this, so feel free to open a PR. |
Beta Was this translation helpful? Give feedback.
1 reply
-
#2823 got merged |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, for the Repository object the ForgeRemoteID has an underlying type of string. This makes completely sense as a forge might use some kind of int or some string (e.g. UUID) for the repository ID. The exact same approach is followed for the User object.
However, for the PullRequest Object, the ID is called
Index
(notForgeRemoteID
) and its type isint64
. This might seems a slightly different approach compared to other entities which follow the previously mention approach. Currently there is no issue with theint64
use as all supported forges use an integer as a Pull Request ID.Taking into consideration that some forges (existing or new) might support non-integer index for Pull Request but also for uniformity reasons I propose this to be refactored and match the rest of the types (
ForgeRemoteID
).I am aware that this might need some refactor and I could work on this.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions