Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge cases #14066

Open
6 tasks
Tracked by #13493
hafizrahman opened this issue Sep 28, 2024 · 1 comment
Open
6 tasks
Tracked by #13493

Edge cases #14066

hafizrahman opened this issue Sep 28, 2024 · 1 comment
Labels
priority: medium Planned tasks usually belonging to ongoing projects

Comments

@hafizrahman
Copy link
Contributor

hafizrahman commented Sep 28, 2024

This issue collects the various edge cases that needs to be handled in various places related to Custom Fields. The list is based on the technical documentation in pe5sF9-33t-p2

List screen

  • Save button needs to be enabled only if new changes (edits, addition, deletion) are detected.
  • Show "discard changes" dialog if new changes are detected and merchants tap "Back" button.
  • Saving banner: expand content by default on Portrait mode, hide in Landscape (Android ref: Issue/12597 custom fields banner woocommerce-android#12601 (comment))

Custom field deletion

  • After a custom field is deleted (from the option in Editor screen), the List screen should show "Undo" notice to cancel it.

Editor screen

  • API doesn't allow adding a new field with existing key. When creating a new custom field, check local storage for all existing keys. If duplicates are found, show alert that field with the same key can't be added in the app, but can be done in wp-admin. No checking is needed for editing existing key.

Product details

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 28, 2024

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

@JorgeMucientes JorgeMucientes added the priority: medium Planned tasks usually belonging to ongoing projects label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Planned tasks usually belonging to ongoing projects
Projects
None yet
Development

No branches or pull requests

3 participants