-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's simplify .col-full selectors #551
Comments
.col-full
selectors
.col-full
selectors
I agree this could be simplified. |
May I ask where the value of the variable |
It's left over from the modular scale we used originally. We should probably update that to use the new |
Also rearranges the order that vendor styles are included in style.scss so that variables.scss has access to ms()
|
How come? Everything else is.
I'm afraid not :( If you can think of a way however a PR would be most welcome :) |
I mean, modular scale is OK for vertical spaces, but I don't like it for horizontal ones. In my opinion, 60em (960px) is a more practical value than 66.4989378333em (1063.9830053328px). |
Reading the stylesheets, I found that the
.col-full
selectors are a mess. The rules:In contrast with the rest of the code,
.col-full
is styled with a desktop-first approach, making it difficult to understand its behavior.So, there is
.col-full
between ∞ and 67.142em, a variant between 67.141em and 768px, a variant between 767px and 569px and another one between 568px and 0.Why not simplify things in a mobile-first way, removing the
max-width
media queries?The text was updated successfully, but these errors were encountered: