Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donot repeatedly call v3_create_commerce_partner_merchant for 409 error #858

Open
adarshakb opened this issue Nov 17, 2023 · 0 comments
Open
Labels
type: bug The issue is a confirmed bug.

Comments

@adarshakb
Copy link

Describe the bug:

v3_create_commerce_partner_merchant is called repeatedly to register merchant. But in some error cases it should not be called. Instead we should stop calling it and ask the merchant to disconnect and reconnect the plugin at a later time after the issue is fixed.

Error 1: Merchant has already connected to other platform
Error 2: You are trying to connect a new domain %s. Please disconnect from the previous domain %s and retry.
example - You are trying to connect a new domain spence550stg.wpengine.com. Please disconnect from the previous domain spencediamonds.com and retry.

Steps to reproduce:

  1. To reproduce error 1 , connect an account in woocommerce thats connected to Pinterest shopify app
  2. To reproduce error 2, connect an account to domain A and then without disconnecting connect to domain B

Expected behavior:

When we encounter 4xx errors we should not repeatedly call the API as most of the errors are not recoverable.

Actual behavior:

App repeatedly calls the API

@adarshakb adarshakb added the type: bug The issue is a confirmed bug. label Nov 17, 2023
@adarshakb adarshakb changed the title Donot repeatedly call v3_create_commerce_partner_merchant Donot repeatedly call v3_create_commerce_partner_merchant for 409 error Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

1 participant