Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 18 build failed #888

Open
Arjit0762 opened this issue Nov 20, 2024 · 10 comments
Open

iOS 18 build failed #888

Arjit0762 opened this issue Nov 20, 2024 · 10 comments

Comments

@Arjit0762
Copy link

Arjit0762 commented Nov 20, 2024

The following build commands failed:
CompileC /Users/expo/Library/Developer/Xcode/DerivedData/ZoopDevelop-fgqtadscqcoewycwvmcbkgxxvcmh/Build/Intermediates.noindex/ArchiveIntermediates/ZoopDevelop/IntermediateBuildFilesPath/Pods.build/Debug-iphoneos/react-native-pdf.build/Objects-normal/arm64/RNPDFPdfView.o /Users/expo/workingdir/build/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-pdf' from project 'Pods')
Archiving workspace ZoopDevelop with scheme ZoopDevelop
(2 failures)
Exit status: 65
+---------------------------------------+
| Build environment |
+-------------+-------------------------+
| xcode_path | /Applications/Xcode.app |
| gym_version | 2.225.0 |
| sdk | iPhoneOS18.1.sdk |

This is the error which I got while making a build in iOS (New Architecture)
"expo": "^52.0.8",
"react-native": "0.76.2",
"react-native-pdf": "6.7.5",
"react-native-blob-util": "0.19.11",
"@config-plugins/react-native-blob-util": "8",
"@config-plugins/react-native-pdf": "8",

This is causing me blocker to move my app to new architecture

@iyansr
Copy link

iyansr commented Nov 21, 2024

Same issue, but i run with sdk 51 and new arch enabled

@iyansr
Copy link

iyansr commented Nov 21, 2024

After i added this
#832
It worked again

enableDoubleTapZoom: ?boolean,

@Arjit0762
Copy link
Author

@iyansr Build is now created, but when I double tapped on pdf file to zoom, my app crashed

@mohamedhelmi70
Copy link

mohamedhelmi70 commented Nov 21, 2024

After i added this #832 It worked again

enableDoubleTapZoom: ?boolean,

search for files with name RNPDFPdfViewProps.
then add this line.
bool enableDoubleTapZoom{true}; // Default value: true

@Arjit0762
Copy link
Author

Arjit0762 commented Nov 22, 2024

Thanks to all, I was able to solve the issse.. @mohamedhelmi70 besides enableDoubleTapZoom: ?boolean, I commented one more line.. I was not able to find RNPDFPdfViewProps file..

I commented onChange line and it worked, though doubleTapZoom is disabled you which is not a major concern for me for now.

@iyansr Thanks for your support

Here is my patch file
react-native-pdf+6.7.5.patch

Note:
If having issue in installing patch file, check https://www.npmjs.com/package/patch-package library.. It updates node_modules post installation of your package. Supported in EAS as well

I am keeping this open till issue is resolved as disabling tap zoom should not be main goal of pdf functionality

@joaonew
Copy link

joaonew commented Nov 24, 2024

Do we have an updated version of this lib to deal with the new arch?

@Arjit0762
Copy link
Author

Arjit0762 commented Nov 25, 2024

@joaonew Use patch file attached in my comment till new version releases.. Yes, it has support for new arch.. Just tap zoom in functionality is having some issue in iOS. so, we have commented tab zoom onChange functionality for iOS in this patch file

@joaonew
Copy link

joaonew commented Nov 27, 2024

@joaonew Use patch file attached in my comment till new version releases.. Yes, it has support for new arch.. Just tap zoom in functionality is having some issue in iOS. so, we have commented tab zoom onChange functionality for iOS in this patch file

Sounds good, I will do it, by the way do we have a timeline for new version release already?

@griffinshuth
Copy link

hopefully soon. this has been a known problem for a while now. It looks like he finally merged in the PR that fixed this issue yesterday but has not cut a new release

@zoobibackups
Copy link

when I create pdf from react-native-html-to-pdf this library then uri is created in iOS :/var/mobile/Containers/Data/Application/E8A5B29E-A1CF-4961-9EC7-D82F6A088925/Documents/CamScan002.pdf
when I attached the bundle-assist://ar/mobile/Containers/Data/Application/E8A5B29E-A1CF-4961-9EC7-D82F6A088925/Documents/CamScanner/Documents/CamScan002.pdf but the pdf cannot show Error Error: Load pdf failed.
In Android we use file:// In IOS how I make the uri with this link to attached in IOS like bundle-assest or any other Please Help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants