-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 18 build failed #888
Comments
Same issue, but i run with sdk 51 and new arch enabled |
After i added this
|
@iyansr Build is now created, but when I double tapped on pdf file to zoom, my app crashed |
search for files with name RNPDFPdfViewProps. |
Thanks to all, I was able to solve the issse.. @mohamedhelmi70 besides enableDoubleTapZoom: ?boolean, I commented one more line.. I was not able to find RNPDFPdfViewProps file.. I commented onChange line and it worked, though doubleTapZoom is disabled you which is not a major concern for me for now. @iyansr Thanks for your support Here is my patch file Note: I am keeping this open till issue is resolved as disabling tap zoom should not be main goal of pdf functionality |
Do we have an updated version of this lib to deal with the new arch? |
@joaonew Use patch file attached in my comment till new version releases.. Yes, it has support for new arch.. Just tap zoom in functionality is having some issue in iOS. so, we have commented tab zoom onChange functionality for iOS in this patch file |
Sounds good, I will do it, by the way do we have a timeline for new version release already? |
hopefully soon. this has been a known problem for a while now. It looks like he finally merged in the PR that fixed this issue yesterday but has not cut a new release |
when I create pdf from react-native-html-to-pdf this library then uri is created in iOS :/var/mobile/Containers/Data/Application/E8A5B29E-A1CF-4961-9EC7-D82F6A088925/Documents/CamScan002.pdf |
The following build commands failed:
CompileC /Users/expo/Library/Developer/Xcode/DerivedData/ZoopDevelop-fgqtadscqcoewycwvmcbkgxxvcmh/Build/Intermediates.noindex/ArchiveIntermediates/ZoopDevelop/IntermediateBuildFilesPath/Pods.build/Debug-iphoneos/react-native-pdf.build/Objects-normal/arm64/RNPDFPdfView.o /Users/expo/workingdir/build/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-pdf' from project 'Pods')
Archiving workspace ZoopDevelop with scheme ZoopDevelop
(2 failures)
Exit status: 65
+---------------------------------------+
| Build environment |
+-------------+-------------------------+
| xcode_path | /Applications/Xcode.app |
| gym_version | 2.225.0 |
| sdk | iPhoneOS18.1.sdk |
This is the error which I got while making a build in iOS (New Architecture)
"expo": "^52.0.8",
"react-native": "0.76.2",
"react-native-pdf": "6.7.5",
"react-native-blob-util": "0.19.11",
"@config-plugins/react-native-blob-util": "8",
"@config-plugins/react-native-pdf": "8",
This is causing me blocker to move my app to new architecture
The text was updated successfully, but these errors were encountered: