Threading Fix #608
Merged
Threading Fix #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejohnstown
requested review from
julek-wolfssl,
JacobBarthelmeh and
kareem-wolfssl
julek-wolfssl
requested changes
Oct 23, 2023
ejohnstown
force-pushed
the
thread-fix
branch
from
44ab214
to
8f71e7d
Compare
julek-wolfssl
previously approved these changes
Oct 23, 2023
1. The wolfSSL version number to check for the old threading code was v5.5.2, not v5.5.1. 2. A new wrapper was introduced around return for threading in what will be wolfSSL v5.6.4. Added that wrapper if it didn't exist. 3. Some other types for threading are added in v5.6.4, wolfSSH needs to use the old threading model if using wolfSSL v5.6.3.
ejohnstown
force-pushed
the
thread-fix
branch
from
8f71e7d
to
92669d0
Compare
JacobBarthelmeh
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing configuration:
Built wolfSSH against wolfSSL v5.5.0, v5.5.1, v5.6.3, and a modified version of the master branch with the version changed to v5.6.4.