Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Error Message Not Included In Message #203

Closed
criminosis opened this issue Apr 18, 2024 · 6 comments · Fixed by #204
Closed

Generic Error Message Not Included In Message #203

criminosis opened this issue Apr 18, 2024 · 6 comments · Fixed by #204

Comments

@criminosis
Copy link
Contributor

@wolf4ood would it be possible to include the wrapped error message in the thiserror annotation for the Generic Error?

I think it'd just need to be changed to something like:

#[error("data store disconnected: {0}")]
Generic(String),

As it stands I keep having this error occur and data store disconnected gets logged, but I don't have any context as to why.

Sort of tangental to the issue but is it expected for when this error occurs to drop the client and manually re-create it? Currently I just keep retrying the same traversal, but once whatever error this is starts to happen it seems to keep failing in my retry loop until I restart the program.

@wolf4ood
Copy link
Owner

Hi @criminosis sure, can you provide a PR for this?

@criminosis
Copy link
Contributor Author

@wolf4ood happily. Pushed it up #204

If you wouldn't mind cutting a release once it's merged I'd appreciate it!

@wolf4ood
Copy link
Owner

Sure i can do the release :)

@criminosis
Copy link
Contributor Author

Thank you!

@wolf4ood
Copy link
Owner

@criminosis released :)

@criminosis
Copy link
Contributor Author

@wolf4ood Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants