Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report version date as Unix epoch instead of preformatted string #23

Open
digitalcircuit opened this issue Apr 2, 2020 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@digitalcircuit
Copy link

In brief

Details

After looking at issue #22, I noticed that iQuassel currently pre-formats the version date instead of reporting the date/time in seconds since the Unix epoch:

QuasselCoreConnection.m

NSString *dateStr = [NSString stringWithFormat:@"%@ %@", [NSString stringWithUTF8String:__DATE__], [NSString stringWithUTF8String:__TIME__]];
[initial setValue:[[QVariant alloc] initWithString:dateStr] forKey:@"ClientDate"];

iQuassel should instead send the version date as the seconds since the Unix epoch, wrapped as a string for backwards compatibility. For example, Quassel desktop does this:

src/common/quassel.cpp

// Set to Unix epoch, wrapped as a string for backwards-compatibility
buildInfo.commitDate = QString::number(GIT_COMMIT_DATE);

Quasseldroid also transmits the ClientDate as a string of seconds since the Unix epoch.

Quassel desktop v0.13 and newer will automatically format this using the date/time locale of the current system, as per the screenshots in the upstream PR.

@guruz guruz added the enhancement New feature or request label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants