Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nick case is always lower #11

Open
lowlyw opened this issue Dec 23, 2019 · 6 comments
Open

nick case is always lower #11

lowlyw opened this issue Dec 23, 2019 · 6 comments
Labels
bug Something isn't working ReadyToTest

Comments

@lowlyw
Copy link
Contributor

lowlyw commented Dec 23, 2019

in the Users scene, the nick case is always show as lowercase same when [quasselCoreConnection ircUsersForChannelWithBufferId:] is called, instead of the actual potentially using uppercase nicknames.

@lowlyw
Copy link
Contributor Author

lowlyw commented Dec 23, 2019

it looks like this is the fault of downcasing everything for string compare, instead of using the option NSCaseInsensitiveSearch

@guruz
Copy link
Member

guruz commented Dec 23, 2019

Old code base and inexperienced objective C developer at the time :-)

@guruz guruz added the bug Something isn't working label Mar 28, 2020
@guruz
Copy link
Member

guruz commented Apr 5, 2020

Actually from checking the code for some minutes I don't see the bug. I'm only doing the lower casing for comparting, not for putting into the data structures?

@lowlyw
Copy link
Contributor Author

lowlyw commented Apr 12, 2020

sorry, i'll do a little digging tomorrow. i caught the virus recently, and i'm able to concentrate again. :)

@guruz
Copy link
Member

guruz commented Apr 12, 2020

oh... well, please also try to sleep, rest, take your zinc+C etc ;-)
get well..

@guruz
Copy link
Member

guruz commented Apr 21, 2020

I found the issue..

@lowlyw hope you are well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ReadyToTest
Projects
None yet
Development

No branches or pull requests

2 participants