Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity base URIs are being added to SNAP relations in the /relation/@passive attributes #41

Closed
wlpotter opened this issue Dec 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working priority

Comments

@wlpotter
Copy link
Owner

Cf. #39

I think when I implemented the change in this comment, I added a test for passive attributes where if they didn't start with 'http' they got the entity base uri added.

See this commit, esp. l. 825 of csv2sroph.xqm there.

Easiest solution is to add "snap" as an 'or' in the condition, but wait on the end result of #35 before implementing.

@wlpotter wlpotter added bug Something isn't working priority labels Dec 15, 2021
@wlpotter wlpotter self-assigned this Dec 15, 2021
@wlpotter
Copy link
Owner Author

wlpotter commented Dec 15, 2021

This is not specific to snap relations. Cf. ISO lang codes: https://github.com/wlpotter/csv-to-srophe/blob/main/test/out/csv-tests/subjects/akkadian-language.xml#L117

Perhaps the test should be if it's just a numerical value assume it's a same-entity URI?

@wlpotter
Copy link
Owner Author

Just testing for numerical values, e.g. match($uri, "\A\d+\Z") to match only if there are numbers in the string wouldn't work if we ever used this on keywords or if the entity used alphanumeric for some reason.

So, I will instead just use 'or' conditionals for starts-with "ISO" or "snap:".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

1 participant