Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in browser for Sass modules not working in Sublime Text #256

Open
1 task done
niksy opened this issue Oct 7, 2024 · 3 comments
Open
1 task done

Open in browser for Sass modules not working in Sublime Text #256

niksy opened this issue Oct 7, 2024 · 3 comments

Comments

@niksy
Copy link
Contributor

niksy commented Oct 7, 2024

In which editor is this a problem?

Sublime Text

Describe the bug

I don’t know if this is related to Sublime LSP or Some Sass, but clicking on "Open in browser" for Sass modules link doesn’t do anything.

Screenshot 2024-10-07 at 20 09 34

What's the expected result?

Sass module documentation is opened in default browser.

Link to minimal reproducible example

No response

Participation

  • I am willing to submit a pull request for this issue.
@wkillerud
Copy link
Owner

I think this is a Sublime or Sublime LSP issue. Some Sass doesn't provide link information for Sass built-in modules.

Here's an example from VS Code, only the pkg: is a clickable link.

@niksy
Copy link
Contributor Author

niksy commented Oct 11, 2024

Yeah, seems like it.

Some Sass doesn't provide link information for Sass built-in modules.

Would it make sense to make them clickable and open official Sass documentation?

@wkillerud
Copy link
Owner

I have had this idea of making a "virtual" file for the built-in modules, kind of like how the TypeScript definitions for JavaScript built-ins work (in VS Code at least). I envision an SCSS file with the module's variable and method names + SassDoc, again similar to type definitions.

Clicking the "sass:math" link in this scenario should, I think, open a virtual file like that at line 1 column 1. We could combine that with hover info for "sass:math", perhaps? And have a link to the Sass docs in the hover info, similar to how hover works on f. ex. math.abs().

JavaScript code navigation. Clicking Object.defineProperty opens the type definitions for Object in general, and defineProperty in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants