Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design - fileExplorePopover #120

Open
11 tasks done
Tracked by #111
Mehrabbruno opened this issue Sep 7, 2022 · 6 comments
Open
11 tasks done
Tracked by #111

Design - fileExplorePopover #120

Mehrabbruno opened this issue Sep 7, 2022 · 6 comments

Comments

@Mehrabbruno
Copy link
Collaborator

Mehrabbruno commented Sep 7, 2022

@todo

#112

@info

This pop-over is designed for to be placed in component tab_v0.0.1

@Mehrabbruno Mehrabbruno mentioned this issue Sep 7, 2022
5 tasks
@Mehrabbruno Mehrabbruno changed the title Design - fileExplorePopover_v0.0.1 pop-over for tabsContainer_v0.0.1 Design - fileExplorePopover_v0.0.1 pop-over for tab_v0.0.1 Sep 7, 2022
@Mehrabbruno Mehrabbruno changed the title Design - fileExplorePopover_v0.0.1 pop-over for tab_v0.0.1 Design - fileExplorePopover Sep 18, 2022
@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 4, 2022

Worklog

Worklog 1 2022.10.21


Tasks

  • done Design - File Explorer pop-over (toggles on onClick). it contians: - 1min
    • done pop-over header (fixed to the top and contains title, total number of file/folder and close button) - 1min
    • done Files container - 1min
      • done Files (contains application or icon, title, and close button) - 1min
      • done Folder (contains folder icon, title, toggle icon, and close button) - 1min
        • done When clicked user gets a dropdown list of children File & Folders - 1min
    • done Record an explanatory video for fileExplorePopover Component and add it in the header description - 1min
    • done Search input (contains search icon, inputField and close icon when added text) - 1min
    • @output 📦 fileExplorePopover_v0.0.1

@serapath
Copy link
Member

feeeback 2022.10.14

same as other issues again:

  1. missing worklog video
  2. missing times behind each done todo

FOr the first iteration, great file explorer.
Definitely something that we might need to iterate quite a lot on based on all the previous TWM work that has been done on file explorer (including files, not just folders) and how some files (e.g. tile.json files) can also be expanded similar to folders to show internal structure, etc... etc... but one thing at a time, so let's first fix all the structure, but then we need to iterate on the file explorer based on previous work :-)

@serapath
Copy link
Member

feedback 2022.10.22

So here there is so much to say, that i would say we should split the work - like in general - into:

  1. fileexplorer popover (which is this issue)
  2. fileexplorer component

The latter might already have an issue here on github in the old TWM1 or TWM2 issues.
There are a some older wireframes and a lot of detailed information hidden in the old wireframes. It would be good if you could try to go through them and collect all those materials, maybe check the file explorer issue (if there is one - i think there is)
And maybe also do search for words like file explorer, file, folder, file tree, file system, etc... on TWM1 and TWM2 issue to collect all the feedback that was already given, so we don't ahve to start all the way from scratch.

The file explorer is a very complex component, inspired by vscode file explorer but generally with lots of features :-)

Maybe we can first bring all other parts as much as possible into a good state and then deep dive into the file explorer on it's own issue to wireframe that in much more detail.

@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 24, 2022

Feedback 2022.10.24

I would say we should split the work - like in general

Could you explain what you mean by this? Why is there a need for a split for this?


an issue here on GitHub in the old TWM1 or TWM2 issue

If you could direct me to an issue or a comment specifically that would be great. There is so much text, half the time I won’t even be able to tell if I am looking at the right place or the right thing.


Maybe we can first bring all other parts as much as possible into a good state and then deep dive into the file explorer

Okay, I will put this in-plan or on-hold.


Proposals 2022.10.24

  • Search for file explorer component information in TWM1 and TWM2 Issues

@serapath
Copy link
Member

feedback 2022.10.26

or maybe then let's not split it yet if you don't see the need. we will see if we get to that point.

I would say, let's finish everything else first and then let's go to the file explorer when we have the the final version for the way how we work ready, so that's done and also all other TWM issues that don't require file explorer yet are done.
we can just create a list of things the file explorer should support to make the TWM work and then we go through TWM1 and TWM2 to find stuff.

I think having the TWM3 ready makes it easy for me to compare everything that was discussed in TWM1 and TWM2 to what we have to decide if we have forgotten something or not, because going through all of that i would like to do only once, because it is a lot.

proposal: add an input document to the file explorer issue that is suppsoed to cintain all the information from TWM1 and TWM2 about the file explorer. We can then create an extra issue for TWM1 and TWM2 summary where we produce that document and i can actually try to produce it and then we know you can't yet work perfectly well on the file explorer issue because that input document is not ready yet :-)

@Mehrabbruno
Copy link
Collaborator Author

Mehrabbruno commented Oct 30, 2022

Worklog

worklog-1 2022.10.31


Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants