feat: Update Fonts #583
Merged
feat: Update Fonts #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabaldon
force-pushed
the
redesign
branch
2 times, most recently
from
25a9e7b
to
c72602c
Compare
gabaldon
requested changes
Oct 7, 2024
...gets/witnet/transactions/value_transfer/create_dialog_box/vtt_builder/01_recipient_step.dart
Show resolved
Hide resolved
parodyBit
force-pushed
the
update_fonts
branch
2 times, most recently
from
963bc30
to
8bc257b
Compare
add Nimbus Mono Font Family for the extended theme
parodyBit
force-pushed
the
update_fonts
branch
from
acfdf18
to
951ebe1
Compare
parodyBit
force-pushed
the
update_fonts
branch
from
951ebe1
to
be6afec
Compare
gabaldon
reviewed
Oct 10, 2024
There was a problem hiding this comment.
The address should be black
| @@ -57,21 +57,21 @@ class GenerateMnemonicCardState extends State<GenerateMnemonicCard> | |||
| children: [ | |||
| Text( | |||
| localization.generateMnemonic01(_radioWordCount), | |||
| style: theme.textTheme.bodyLarge, | |||
| style: theme.textTheme.bodyMedium, | |||
There was a problem hiding this comment.
The mnemonic fontSize is too small. Also the description text seems a bit too small too.
gabaldon
requested changes
Oct 10, 2024
| @@ -40,7 +40,7 @@ class InitScreenState extends State<InitScreen> with TickerProviderStateMixin { | |||
| ), | |||
| Text( | |||
| localization.welcome, | |||
| style: theme.textTheme.displayLarge, | |||
| style: theme.textTheme.displayLarge?.copyWith(height: 0), | |||
There was a problem hiding this comment.
Avoid modifying the height here
| @@ -181,7 +181,7 @@ class GeneralConfigState extends State<GeneralConfig> { | |||
| localization.theme, | |||
| style: theme.textTheme.titleMedium, | |||
| ), | |||
| SizedBox(height: 16), | |||
| SizedBox(height: 10), | |||
There was a problem hiding this comment.
why are you modifying the sizedBox?
| @@ -190,15 +190,16 @@ class GeneralConfigState extends State<GeneralConfig> { | |||
| style: theme.textTheme.titleMedium, | |||
| ), | |||
| PaddedButton( | |||
| padding: EdgeInsets.only(bottom: 16, top: 16), | |||
| padding: EdgeInsets.only(bottom: 16, top: 10), | |||
There was a problem hiding this comment.
Avoid modifying the padding
| text: localization.lockWalletLabel, | ||
| type: ButtonType.primary, | ||
| enabled: true, | ||
| onPressed: () => logout(context)), | ||
| SizedBox(height: 16), | ||
| SizedBox(height: 12), |
There was a problem hiding this comment.
Avoid modfying the sizedBox
| Text( | ||
| localization.versionNumber(VERSION_NUMBER), | ||
| style: theme.textTheme.titleSmall, | ||
| style: theme.textTheme.bodyMedium | ||
| ?.copyWith(fontWeight: FontWeight.w700), |
There was a problem hiding this comment.
Avoid modifying the weight here
lib/widgets/switch.dart
Outdated
| @@ -27,7 +27,7 @@ class CustomSwitch extends StatelessWidget { | |||
| padding: EdgeInsets.only(left: 16), | |||
| child: Text( | |||
| primaryLabel, | |||
| style: theme.textTheme.bodyLarge, | |||
| style: theme.textTheme.bodyMedium?.copyWith(fontSize: 14), | |||
There was a problem hiding this comment.
avoid modifying the fontSize here
lib/widgets/transaction_item.dart
Outdated
| @@ -66,7 +66,7 @@ class TransactionsItemState extends State<TransactionsItem> { | |||
| transacionStatusCopy, | |||
| textAlign: TextAlign.start, | |||
| overflow: TextOverflow.ellipsis, | |||
| style: theme.textTheme.bodySmall, | |||
| style: theme.textTheme.bodyMedium?.copyWith(fontSize: 11), | |||
There was a problem hiding this comment.
Avoid modifying the size here
lib/widgets/transaction_item.dart
Outdated
| Text(address, | ||
| overflow: TextOverflow.fade, | ||
| style: extendedTheme.monoRegularText | ||
| ?.copyWith(fontSize: 14)) |
There was a problem hiding this comment.
Lets create an extended theme for different mono font sizes
lib/widgets/transactions_list.dart
Outdated
| @@ -120,7 +120,7 @@ class TransactionsListState extends State<TransactionsList> { | |||
| if (widget.transactions.length > 0) { | |||
| return ListView.builder( | |||
| controller: _scroller, | |||
| padding: EdgeInsets.only(top: 8), | |||
| padding: EdgeInsets.only(top: 4), | |||
| @@ -116,7 +116,8 @@ class WalletListState extends State<WalletList> { | |||
| padding: EdgeInsets.all(0), | |||
| text: localization.createOrImportLabel, | |||
| color: theme.textTheme.displayMedium!.color, | |||
| boldText: true, | |||
| fontSize: 13, | |||
There was a problem hiding this comment.
Avoid modifying the fontSize here
gabaldon
approved these changes
Oct 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fonts to match the redesign
close #581