-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vite 6.0.0-beta.6 #12323
Update to Vite 6.0.0-beta.6 #12323
Conversation
🦋 Changeset detectedLatest commit: e86fb69 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There's an off-by-one error in the reported line by sass. Will have to check if this is a bug in Vite or not. |
vitejs/vite#18522 should fix it but we can also fix on our side as it's not really a vite breaking change. |
I'm planning to bump to beta.6 first, and then bump to beta.8 later as it has more e2e errors that I've not been able to look at yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
@bluwy can we bump to import data from '@gen/data.json' assert { type: 'json' };
export const getStaticPaths = async () => {
return data;
}; |
I just checked the compat and there's a change in beta.8 that's breaking svelte and solid integrations, so we can't bump it yet. However if you're not using them, you can use |
I am using svelte and had to do this to fix the issue vite{
resolve: {
conditions: ['browser'],
},
} |
Changes
Update to latest beta, which shouldn't have any issues for us.
Testing
Existing tests should pass. Vite ecosystem-ci doesn't test e2e, so would be interesting to see the result here
Docs
n/a