Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vite 6.0.0-beta.6 #12323

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Update to Vite 6.0.0-beta.6 #12323

merged 3 commits into from
Nov 6, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 28, 2024

Changes

Update to latest beta, which shouldn't have any issues for us.

Testing

Existing tests should pass. Vite ecosystem-ci doesn't test e2e, so would be interesting to see the result here

Docs

n/a

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: e86fb69

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 28, 2024
@bluwy
Copy link
Member Author

bluwy commented Oct 28, 2024

There's an off-by-one error in the reported line by sass. Will have to check if this is a bug in Vite or not.

@bluwy
Copy link
Member Author

bluwy commented Oct 30, 2024

vitejs/vite#18522 should fix it but we can also fix on our side as it's not really a vite breaking change.

@bluwy bluwy marked this pull request as draft October 31, 2024 14:34
@bluwy bluwy marked this pull request as ready for review November 6, 2024 14:14
@bluwy
Copy link
Member Author

bluwy commented Nov 6, 2024

I'm planning to bump to beta.6 first, and then bump to beta.8 later as it has more e2e errors that I've not been able to look at yet.

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Nov 6, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@bluwy bluwy merged commit c280655 into next Nov 6, 2024
14 checks passed
@bluwy bluwy deleted the vite-beta-6 branch November 6, 2024 14:51
@Mravuri96
Copy link

@bluwy can we bump to 6.0.0-beta.9, this fix vitejs/vite#18541 which landed in beta.8, will unblock this use case.

import data from '@gen/data.json' assert { type: 'json' };

export const getStaticPaths = async () => {
   return data;
};

@bluwy
Copy link
Member Author

bluwy commented Nov 8, 2024

I just checked the compat and there's a change in beta.8 that's breaking svelte and solid integrations, so we can't bump it yet. However if you're not using them, you can use overrides in your package.json to use the latest beta if needed.

@Mravuri96
Copy link

I just checked the compat and there's a change in beta.8 that's breaking svelte and solid integrations, so we can't bump it yet. However if you're not using them, you can use overrides in your package.json to use the latest beta if needed.

I am using svelte and had to do this to fix the issue

vite{
  resolve: {
    conditions: ['browser'],
  },
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants