Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): output build directory #437

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

ematipico
Copy link
Member

Changes

Closes #430
Closes PLT-2625

My latest PR that unified the adapters had a regression where the output directory couldn't be determined when astro:config:setup was called.

The adapter uses known directories that Vercel uses to deploy the assets. These directories are set when Astro triggers astro:config:setup, and these directories depend on buildOutput. However, in Astro v5 this value isn't the final value inside astro:config:setup.

For this reason, the directories are computed at the end of the build, instead. Based on that, we copy the assets to the correct folder.

Testing

The current tests should still be valid

Docs

N/A

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 5768ff4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@astrojs/vercel Patch
@test/astro-vercel-basic Patch
@test/astro-vercel-image Patch
@test/vercel-isr Patch
@test/vercel-max-duration Patch
@test/vercel-edge-middleware-with-edge-file Patch
@test/vercel-edge-middleware-without-edge-file Patch
@test/astro-vercel-no-output Patch
@test/astro-vercel-prerendered-error-pages Patch
@test/astro-vercel-redirects-serverless Patch
@test/astro-vercel-redirects Patch
@test/vercel-server-islands Patch
@test/astro-vercel-serverless-prerender Patch
@test/astro-vercel-serverless-with-dynamic-routes Patch
@test/astro-vercel-static-assets Patch
@test/astro-vercel-static Patch
@test/vercel-streaming Patch
@test/astro-vercel-with-web-analytics-enabled-output-as-static Patch
vercel-hosted-astro-project Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: vercel Related to Vercel adapter (scope) label Nov 8, 2024
packages/vercel/src/index.ts Outdated Show resolved Hide resolved
@ematipico ematipico merged commit b725b49 into next Nov 11, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
@florian-lefebvre florian-lefebvre deleted the fix/regression-build-value branch November 15, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: vercel Related to Vercel adapter (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants