Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP Eclipse compatability #183

Open
wants to merge 1 commit into
base: 1.20.2
Choose a base branch
from

Conversation

Kas-tle
Copy link

@Kas-tle Kas-tle commented Oct 8, 2023

Currently, the annotation processor is not compatabile with eclipse because eclipse will not recognize classes that do not exist in the proper filepath for their respective package.

This also ensures multiple configs with the same name would not collide in the event of multiple configs with the same name.

Signed-off-by: Joshua Castle <[email protected]>
Copy link
Member

@gliscowo gliscowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I approve of the general goal of this PR, it does not at all follow the code style of the rest of this codebase. Namely, local variables should use var instead of explicit type and names must not use abbreviations unless absolutely necessary or commonly established.

Further, I'm not really comfortable with how this handles a package-less class. While those is certainly unlikely to ever actually encounter, they should be correctly handled nonetheless instead of simply prepending a leading period to the wrapper name. While fixing this I would also move this logic into the function where's being used - in my opinion there is little use in having it live hundreds of lines away in its own function when this is the only place it's used

@Dragon-Seeker
Copy link
Member

@Kas-tle Any update to such PR at all or attempts to change such to resolve issues from @gliscowo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants